Clarify choose_version() prompt for use_release_issue() (r-lib#1359)

dragosmg · Feb 9, 2021 · cefd16a · cefd16a
1 parent 762daec
commit cefd16a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/R/release.R b/R/release.R
@@ -25,7 +25,7 @@ use_release_issue <- function(version = NULL) {
     }
   }
 
-  version <- version %||% choose_version()
+  version <- version %||% choose_version("What should the release version be?")
   if (is.null(version)) {
     return(invisible(FALSE))
   }

diff --git a/R/version.R b/R/version.R
@@ -42,7 +42,7 @@ use_version <- function(which = NULL) {
     msg = "There are uncommitted changes and you're about to bump version"
   )
 
-  new_ver <- choose_version(which)
+  new_ver <- choose_version("What should the new version be?", which)
   if (is.null(new_ver)) {
     return(invisible(FALSE))
   }
@@ -75,7 +75,7 @@ use_dev_version <- function() {
   use_version(which = "dev")
 }
 
-choose_version <- function(which = NULL) {
+choose_version <- function(message, which = NULL) {
   ver <- desc::desc_get_version(proj_get())
   versions <- bump_version(ver)
 
@@ -85,7 +85,8 @@ choose_version <- function(which = NULL) {
         "{format(names(versions), justify = 'right')} --> {versions}"
       ),
       title = glue(
-        "Current version is {ver}.\n", "Which part to increment? (0 to exit)"
+        "Current version is {ver}.\n",
+        "{message} (0 to exit)"
       )
     )
     if (choice == 0) {