Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Attempt to mount using mountByAPI without makeConfig #1604

Closed
wants to merge 7 commits into from

Conversation

fappy1234567
Copy link
Contributor

Details

  • Implement mounting through mountByAPI to evaluate its effectiveness.
  • Omit the use of makeConfig

@fappy1234567 fappy1234567 requested a review from a team as a code owner July 22, 2024 14:10
@fappy1234567 fappy1234567 requested review from imeoer, jiangliu and ccx1024cc and removed request for a team July 22, 2024 14:10
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.42%. Comparing base (a6bd8cc) to head (56e0ed7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
- Coverage   61.43%   61.42%   -0.02%     
==========================================
  Files         145      145              
  Lines       48032    48032              
  Branches    46007    46007              
==========================================
- Hits        29509    29502       -7     
- Misses      16963    16968       +5     
- Partials     1560     1562       +2     

see 2 files with indirect coverage changes

@fappy1234567 fappy1234567 requested a review from a team as a code owner July 24, 2024 07:09
@fappy1234567 fappy1234567 requested review from bergwolf and removed request for a team July 24, 2024 07:09
@fappy1234567 fappy1234567 force-pushed the MountByAPI branch 2 times, most recently from 56e0ed7 to 706dc97 Compare July 24, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants