fix(search_family): Remove the output of extra fields in the FT.AGGREGATE command #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GATE command fixes dragonflydb#4230 Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
df.search/fix-aggregate-steps-result
branch
from
8affbf7
to
c108b12
Compare
romange
reviewed
Nov 29, 2024
| // TODO: Replace DocValues with compact linear search map instead of hash map | ||
| struct PipelineResult { | ||
| // Values to be passed to the next step | ||
| // TODO: Replace DocValues with compact linear search map instead of hash map |
There was a problem hiding this comment.
is this TODO relevant? I do not see a hash map here
romange
reviewed
Nov 29, 2024
| }; | ||
| } | ||
|
|
||
| PipelineResult Process(std::vector<DocValues> values, absl::Span<const PipelineStep> steps) { | ||
| PipelineResult Process(std::vector<DocValues> values, |
There was a problem hiding this comment.
Please put your prod-duty hat, and think about all the VLOG statements you would like to have, if we have problems in production with this code.
BorysTheDev
reviewed
Nov 30, 2024
Comment on lines
+127
to
+129
| if (descending) { | ||
| std::reverse(values.begin(), values.end()); | ||
| return values; | ||
| } |
There was a problem hiding this comment.
instead of reverse, you can do correct sorting
BorysTheDev
reviewed
Nov 30, 2024
| return result; | ||
| values = std::move(result.value()); | ||
| PipelineResult step_result = step(std::move(result)); | ||
| result = std::move(step_result); |
There was a problem hiding this comment.
I would prefer to see step method modifying the result instead of all these moves
BorysTheDev
reviewed
Nov 30, 2024
| using PipelineResult = io::Result<std::vector<DocValues>, facade::ErrorReply>; | ||
| using PipelineStep = std::function<PipelineResult(std::vector<DocValues>)>; // Group, Sort, etc. | ||
| // Fields from values to be printed | ||
| absl::flat_hash_set<std::string> fields_to_print; |
BorysTheDev
reviewed
Nov 30, 2024
Comment on lines
+1006
to
+1007
| auto it = value.find(field); | ||
| if (it != value.end()) { |
There was a problem hiding this comment.
nit: if (auto it = value.find(field); it != value.end())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4230
First PR for complete support of the SORTBY option (#3631)
To see examples please check the issue.
Add code that checks, during aggregate steps, what fields should be printed.