Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove oom_deny_ratio flag #4139

Open
adiholden opened this issue Nov 17, 2024 · 0 comments · May be fixed by #4142
Open

remove oom_deny_ratio flag #4139

adiholden opened this issue Nov 17, 2024 · 0 comments · May be fixed by #4142
Assignees
@BagritsevichStepan
Labels
Next Up task that is ready to be worked on and should be added to working queue

Comments

@adiholden
Copy link
Collaborator

  1. flag should be deprecated use ABSL_RETIRED_FLAG
  2. server logic should still reject denyoom commands when server reaches max_memory_limit (as if we run with oom_deny_ratio=1.0)
  3. today in some test we use the oom_deny_ratio flag test eviction. we need to fix this test by tuning when eviction starts, today this is hardcoded at 95% usage, we can tune eviction with a new flag
@adiholden adiholden added the Next Up task that is ready to be worked on and should be added to working queue label Nov 18, 2024
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 21, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
32440fc 
fixes dragonflydb#4139

Signed-off-by: Stepan Bagritsevich <[email protected]>
This was referenced Nov 21, 2024
Open
Closed
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 23, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
5e6c873 
fixes dragonflydb#4139

Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 25, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
b904f26 
fixes dragonflydb#4139

Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 26, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
0caf3ae 
fixes dragonflydb#4139

Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 26, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
67770b4 
fixes dragonflydb#4139

Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 26, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
b5a5a7b 
fixes dragonflydb#4139

Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 28, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
129dc58 
fixes dragonflydb#4139

Signed-off-by: Stepan Bagritsevich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BagritsevichStepan BagritsevichStepan

Labels
Next Up task that is ready to be worked on and should be added to working queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eviction): Tune eviction threshold in cache mode BagritsevichStepan/dragonfly
2 participants
@BagritsevichStepan @adiholden