Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune eviction threshold in cache mode #4011

Closed
adiholden opened this issue Oct 29, 2024 · 2 comments
Closed

Tune eviction threshold in cache mode #4011

adiholden opened this issue Oct 29, 2024 · 2 comments
Assignees
@BagritsevichStepan
Labels
bug Something isn't working Next Up task that is ready to be worked on and should be added to working queue

Comments

@adiholden
Copy link
Collaborator

Today eviction starts on 90% memory usage in cache mode
If we set deny_oom_flag to lower than 90% then we reject writes and no eviction is taking place.
We need to set the threshold so it will take into account this flag
@adiholden adiholden added the bug Something isn't working label Oct 29, 2024
@adiholden adiholden added the Next Up task that is ready to be worked on and should be added to working queue label Oct 29, 2024
@adiholden
Copy link
Collaborator Author

adiholden commented Nov 5, 2024 •
edited
Loading

flag names : rss_oom_deny_ratio oom_deny_ratio
pytest for reference how to check eviction : test_heartbeat_eviction_propagation

BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 18, 2024
@BagritsevichStepan
cache(cache_mode): Tune eviction threshold in cache mode
cdd7fc0 
fixes dragonflydb#4011

Signed-off-by: Stepan Bagritsevich <[email protected]>
@BagritsevichStepan BagritsevichStepan mentioned this issue Nov 18, 2024
Open
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 18, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
b5e1611 
fixes dragonflydb#4011

Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 18, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
1d7035c 
fixes dragonflydb#4011

Signed-off-by: Stepan Bagritsevich <[email protected]>
@BagritsevichStepan
Copy link
Contributor

BagritsevichStepan commented Nov 21, 2024 •
edited
Loading

Another issue (#4139) was created for this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BagritsevichStepan BagritsevichStepan

Labels
bug Something isn't working Next Up task that is ready to be worked on and should be added to working queue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BagritsevichStepan @adiholden