-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix startup parameter issue for samba version 4.15+ #405
base: master
Are you sure you want to change the base?
Conversation
Replace parameter "S" from the "-FS" startup script to "--debug-stdout", as the "--log-stdout" parameter was replaced to "--debug-stdout" in smbd version 4.15+
I just ran into this, too. Thanks. //Edit: should mention: to make this work you also need to update to a recent version of alpine, e.g by specifying @dperson would you have some time to review this? Much appreciated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me, nice found. This should really be merged 👍
Hello, any updates on this? |
Pls merge, i wasted my whole day on this... |
@derGraph I simply migrated to @crazy-max's Samba container, GitHub, Docker Hub, GHCR. Not a direct solution to this issue, but works nicely for my case. |
This changed in smbd 4.15 and was discussed in dperson#405.
This changed in smbd 4.15 and was discussed in dperson#405.
This changed in smbd 4.15 and was discussed in dperson#405.
This changed in smbd 4.15 and was discussed in dperson#405.
I fixed this in my fork https://github.com/morremeyer/samba which I intend to maintain as I use the image myself. Caveat: I removed functionality that I don't want to maintain, namely multi-arch (it's x86 only) and the docker-compose file. |
I added it to my fork. And I support arm/v7, arm64/v8, amd64 platforms DockerHub: https://hub.docker.com/r/upagge/samba |
I run into the same issue today and the parameter replacement works for me. Is there a reason why the changes cannot merged into main? Is this project still supported by someone? As far i can see, the dockerfile in the master branch does not work for over one year (without manual operation). |
I have no information about that! |
It seems abandoned |
I still maintain and update the image regularly. |
Replace parameter "S" from the "-FS" startup script to "--debug-stdout", as the "--log-stdout" parameter was replaced to "--debug-stdout" in smbd version 4.15+ as we can see here.
If we try to create a new docker image using the current dperson/samba repository and run it, the smbd service won't start. This PR fixes the startup issue caused by an inexistent parameter in the latest version, replacing it with its substitute parameter.