upgrade aws go sdk to v2 #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rt-joe
commented
May 16, 2024
| return func(w http.ResponseWriter, r *http.Request) { | ||
| compressed, err := ioutil.ReadAll(r.Body) | ||
| compressed, err := io.ReadAll(r.Body) |
rt-joe
commented
May 16, 2024
| return p.callCount <= 2 | ||
| } | ||
|
|
||
| func (p *PaginatorMock) NextPage(ctx context.Context, optFns ...func(*timestreamquery.Options)) (*timestreamquery.QueryOutput, error) { |
There was a problem hiding this comment.
HasMorePages() and NextPage() mocks are hacky but I just wanted to get the tests passing
|
Hi @rt-joe, can you please squash your commits? |
rt-joe
force-pushed
the
upgrade-go-sdk-v2
branch
2 times, most recently
from
3c185e4
to
ff30305
Compare
|
@dpattmann commits squashed. Note I have not been able to test this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades aws go sdk v1 to v2. AWS announced end-of-support for go sdk v1 starting July 31, 2025.
Migration guide