Android: direct getExternalSdCardDetails without permission request #501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
Listing the external SD cards is currently asking for permissions.
But the SDK 33 permission change made me look more into this, as asking for MEDIA related permissions seems strange.
This permission request has been removed as tests confirm that all SD cards are correctly fetched without them in various Android versions.
Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
What testing has been done on existing functionality?
Built a testApp with targetSDK 33, installed on emulators API 28, 29, 30, 32, and 33,
Then I checked the SD cards listing is returning correct values, no error, and without asking for any permission.
Other information
Tests done in the context of apache/cordova-plugin-file#597.