Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: confirmation-modal component #846

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

s223749059
Copy link
Contributor

@s223749059 s223749059 commented May 14, 2024

Description

Migrate the confirmation-modal component from CoffeeScript and Angular.js to TypeScript and Angular. The component is used at unit-tutorials-list component. It creates a confirmation dialog when users decide to delete a unit task. The action can be performed under aconvenor and aadmin account privileges.

How Has This Been Tested?

  • First, log in as aconvenor or aadmin acount.
  • Under the Administration section, select Units.
  • After choosing a specific unit name, select the Tasks tab.
  • In that, there is a list of unit tasks. Click on the red delete icon, it displays the confirmation dialog. Users can perform delete actions and receive alert messages on the top right hand side.

Before:

sit782_migrate_confirmation_modal_doubtfire_lms_before

After:

sit782_migrate_confirmation_modal_doubtfire_lms_after
  • Successful delete a unit task:
sit782_migrate_confirmation_modal_doubtfire_lms_delete_function
  • Error handling:
sit782_migrate_confirmation_modal_doubtfire_lms_cancel_function

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Member

@macite macite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the html to use material components before this can be merged.

@b0ink b0ink mentioned this pull request Aug 11, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants