Update index.py (#159)

在操作时都需要判断 ticket 当前是否能够进行操作，处于 pending 状态下才能操作关闭/通过/拒绝
douban · Oct 9, 2023 · 456860a · 456860a
1 parent 2d46f0a
commit 456860a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/helpdesk/views/api/index.py b/helpdesk/views/api/index.py
@@ -157,13 +157,13 @@ async def ticket_op(ticket_id: int, op: str,
     ticket = await Ticket.get(ticket_id)
     if not ticket:
         raise HTTPException(status_code=404, detail='Ticket not found')
+    if ticket.status != "pending":
+        raise HTTPException(status_code=400, detail='Ticket not pending, can not be operated')
 
     if op == 'close':
         "申请人才可主动关闭工单"
         if ticket.submitter != current_user.name:
             raise HTTPException(status_code=403, detail='Permission denied, only submitter can close')
-        if ticket.status != "pending":
-            raise HTTPException(status_code=400, detail='Ticket not pending, can not be closed')
         ticket.annotate(closed=True)
         ticket.confirmed_by = current_user.name
         ticket.confirmed_at = datetime.now()