Added benchmarks for larger regex fsm and runtime benchmarks for the same #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
enhancement
tests
Comment on lines
+59
to
+62
| for token in fsm.allowed_token_ids(start_state): | ||
| # Access every end state individually, to get an amortized | ||
| # cost of dictionary accesses. | ||
| next_state = fsm.next_state(start_state, token) |
There was a problem hiding this comment.
As mentioned previously, let's split these into to separate benchmarks.
|
Thanks for this work, it's really important that we prevent performance degradation! Related / conflicting PR which moves tests from If you're looking to add additional benchmarks after this PR, you might consider adapting some benchmarks from #587 there's a lot of benchmarks in there for CFG generation. |
|
Hi @kc611 the ASV infrastructure is in Here is an example :https://github.com/outlines-dev/outlines/blob/main/benchmarks/bench_regex_guide.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step towards #549,
This PR adds a lager regex benchmark and a few runtime benchmarks.