Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default generate behavior from fixed seed to random seed #228

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Change default generate behavior from fixed seed to random seed #228

merged 2 commits into from
Sep 11, 2023

Conversation

mondaychen
Copy link
Contributor

resolves #221

@rlouf
Copy link
Member

rlouf commented Aug 16, 2023

Is this ready for review? The tests failed for an unrelated reason: interegular's indexing is non-deterministic. This will be fixed in #178 but is not blocker here

@mondaychen
Copy link
Contributor Author

@rlouf It's ready for review! But I think it might be better to merge this after #223 is fixed to avoid confusion

@rlouf rlouf marked this pull request as ready for review August 16, 2023 15:33
@rlouf rlouf added text Linked to text generation enhancement labels Aug 16, 2023
@brandonwillard brandonwillard added the structured generation Linked to structured generation label Sep 11, 2023
@brandonwillard brandonwillard merged commit cbc7c7f into main Sep 11, 2023
4 checks passed
@brandonwillard brandonwillard deleted the update_rng branch September 11, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement structured generation Linked to structured generation text Linked to text generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-seeded generations by default?
3 participants
@mondaychen @rlouf @brandonwillard