Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json call with multi-function enums #1277

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

g-prz
Copy link
Contributor

@g-prz g-prz commented Nov 21, 2024

This PR aims at solving #1217

@g-prz g-prz force-pushed the add-enum-with-multi-function branch from 8840289 to f8d7809 Compare November 21, 2024 15:12
@g-prz
Copy link
Contributor Author

g-prz commented Nov 21, 2024

Hey @rlouf 🙋‍♂️
By any chance, do you have a PR template?
Otherwise ready for review

@g-prz g-prz force-pushed the add-enum-with-multi-function branch from f8d7809 to 66ef685 Compare November 21, 2024 15:16
@g-prz g-prz mentioned this pull request Nov 22, 2024
@g-prz g-prz force-pushed the add-enum-with-multi-function branch 2 times, most recently from 3be775b to ae73d98 Compare November 27, 2024 16:02
@g-prz
Copy link
Contributor Author

g-prz commented Nov 27, 2024

Hey @rlouf
Just fixed the failing test, but seems there is an issue with a HF token? Is this known?

@rlouf
Copy link
Member

rlouf commented Nov 27, 2024

I just realized this. They actually removed one of the models we used for testing, will fix that in another PR.

@rlouf rlouf force-pushed the add-enum-with-multi-function branch from 12cce57 to 2312c82 Compare November 27, 2024 18:16
@rlouf
Copy link
Member

rlouf commented Nov 27, 2024

Rebased the branch and changed the commit name to follow the repo's conventions.

@rlouf rlouf merged commit e9485cf into dottxt-ai:main Nov 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants