Updated mlx-lm kvcache creation #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm, it fix #1225 |
Same, I had the same problem, and this small update was an immediate fix. |
|
Thank you for your contribution. Really appreciate you adding tests! |
|
The tests fail for unrelated reasons. I fixed the styling issue and force-pushed on your branch |
|
Thank for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to match the latest version of mlx-lm (and updated requirements to mlx-lm>=0.19.2)
Also wrote a short test file.
See this commit in mlx-lm where the KVCache was updated: ml-explore/mlx-examples#1015
This fixes #1225