Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ubuntu 18 from appveyor.yml. #497

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

kayoub5
Copy link
Collaborator

@kayoub5 kayoub5 commented Jan 3, 2024

Spin off #495

Ubuntu 18.04 already reached end of life (only paid Extended Security Maintenance is available), so it would make sense to just remove Ubuntu from AppVeyor

Reference: https://ubuntu.com/blog/ubuntu-18-04-eol-for-devices

Resolves #396

@kayoub5 kayoub5 changed the title Remove Ubuntu 18 from appveyor.yml Remove Ubuntu 18 from appveyor.yml. Resolves #396 Jan 3, 2024
@kayoub5 kayoub5 changed the title Remove Ubuntu 18 from appveyor.yml. Resolves #396 Remove Ubuntu 18 from appveyor.yml. Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dfdd42) 82.89% compared to head (e291416) 82.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files          51       51           
  Lines        2823     2823           
  Branches      312      312           
=======================================
  Hits         2340     2340           
  Misses        361      361           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kayoub5 kayoub5 requested review from chmorgan and PhyxionNL January 3, 2024 17:23
@kayoub5 kayoub5 self-assigned this Jan 3, 2024
@kayoub5 kayoub5 merged commit dbf3b58 into master Jan 3, 2024
10 checks passed
@kayoub5 kayoub5 deleted the chore/remove_ubuntu_18 branch January 3, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize appveyor CI
2 participants