Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12777 Keyboard tooltip of toolStripDropDownButton item still displaying when tab to other control #12797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Jan 16, 2025

fix #12777

Proposed changes

  • add hiding ToolTip logic, When toolstrip loses focus,

Customer Impact

  • now tooltip can disappear.

Screenshots

Before

10.0.mp4

After

issues_12777_01.mp4

Test methodology

  • manual

Test environment(s)

10.0.0-alpha.1.25064.15

Microsoft Reviewers: Open in CodeFlow

@Epica3055 Epica3055 requested a review from a team as a code owner January 16, 2025 09:48
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19553%. Comparing base (776484e) to head (8c644e4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12797         +/-   ##
===================================================
+ Coverage   76.18249%   76.19553%   +0.01304%     
===================================================
  Files           3194        3195          +1     
  Lines         640365      640405         +40     
  Branches       47239       47239                 
===================================================
+ Hits          487846      487960        +114     
+ Misses        148983      148923         -60     
+ Partials        3536        3522         -14     
Flag Coverage Δ
Debug 76.19553% <100.00000%> (+0.01304%) ⬆️
integration 18.15155% <100.00000%> (-0.01169%) ⬇️
production 50.13919% <100.00000%> (+0.02161%) ⬆️
test 97.02394% <ø> (+0.00397%) ⬆️
unit 47.53953% <100.00000%> (-0.00017%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jan 16, 2025
@Tanya-Solyanik
Copy link
Member

@Epica3055 - please send this to the test team for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard tooltip of toolStripDropDownButton item still displaying when tab to other control
2 participants