Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for LinkAreaEditor #12718

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Liv-Goh
Copy link
Contributor

@Liv-Goh Liv-Goh commented Jan 7, 2025

Related #10773

Proposed changes

  1. Add unit test LinkAreaEditorTests.cs for public properties and method of the LinkAreaEditor.
  2. Enable nullability in LinkAreaEditorTests.cs.
Microsoft Reviewers: Open in CodeFlow

@Liv-Goh Liv-Goh requested a review from a team as a code owner January 7, 2025 05:57
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.13827%. Comparing base (aaac41d) to head (a3635f7).
Report is 19 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12718         +/-   ##
===================================================
+ Coverage   76.03780%   76.13827%   +0.10047%     
===================================================
  Files           3181        3186          +5     
  Lines         639670      639920        +250     
  Branches       47215       47230         +15     
===================================================
+ Hits          486391      487224        +833     
+ Misses        149759      149177        -582     
+ Partials        3520        3519          -1     
Flag Coverage Δ
Debug 76.13827% <96.87500%> (+0.10047%) ⬆️
integration 18.18896% <ø> (+0.01515%) ⬆️
production 50.04411% <ø> (+0.21159%) ⬆️
test 97.02815% <96.87500%> (-0.00326%) ⬇️
unit 47.23094% <ø> (+0.17572%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Liv-Goh Liv-Goh added the waiting-review This item is waiting on review by one or more members of team label Jan 7, 2025
@Tanya-Solyanik Tanya-Solyanik merged commit 0cf1885 into dotnet:main Jan 8, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Jan 8, 2025
ricardobossan pushed a commit to ricardobossan/winforms that referenced this pull request Jan 9, 2025
Related dotnet#10773

Proposed changes
Add unit test LinkAreaEditorTests.cs for public properties and method of the LinkAreaEditor.
Enable nullability in LinkAreaEditorTests.cs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants