Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for UserControlDocumentDesigner #12710

Conversation

chaowendy
Copy link
Contributor

@chaowendy chaowendy commented Jan 6, 2025

Related #10773

Proposed changes

  • Add unit test UserControlDocumentDesignerTests.cs for public properties and method of the UserControlDocumentDesigner.UserControlDocumentDesigner.
  • Enable nullability in UserControlDocumentDesignerTests.cs.
Microsoft Reviewers: Open in CodeFlow

@chaowendy chaowendy requested a review from a team as a code owner January 6, 2025 01:59
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02877%. Comparing base (aaac41d) to head (d019cea).
Report is 37 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12710          +/-   ##
====================================================
+ Coverage   76.03780%   97.02877%   +20.99096%     
====================================================
  Files           3181        1197        -1984     
  Lines         639670      355711      -283959     
  Branches       47215        5457       -41758     
====================================================
- Hits          486391      345142      -141249     
+ Misses        149759        9761      -139998     
+ Partials        3520         808        -2712     
Flag Coverage Δ
Debug 97.02877% <100.00000%> (+20.99096%) ⬆️
integration ?
production ?
test 97.02877% <100.00000%> (-0.00264%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@chaowendy
Copy link
Contributor Author

@dotnet-policy-service agree company="Microsoft"

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jan 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 7, 2025
@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 10, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 847499e into dotnet:main Jan 10, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 10, 2025
@chaowendy chaowendy deleted the add-unit-test-for-UserControlDocumentDesigner branch January 13, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants