Shorten long lines in VB REVIEW (3rd) AFTER #12489 DRAFT

Directory.Build.targets

@@ -3,9 +3,12 @@
   <Import Project="$(RepositoryEngineeringDir)Analyzer.targets" />
   <Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />
   <Import Project="$(RepositoryEngineeringDir)packageContent.targets" />
-  <Import Project="$(RepositoryEngineeringDir)versioning.targets" />
   <Import Project="$(RepositoryEngineeringDir)Test.targets" Condition="'$(IsTestProject)' == 'true' "/>
 
+  <PropertyGroup>
+    <Description Condition="'$(Description)' == ''">$(AssemblyName)</Description>
+  </PropertyGroup>
+
   <!-- CA1416 Validate platform compatibility. Do not apply to netstandard as it does not have the attribute. -->
   <ItemGroup>
     <AssemblyAttribute Include="System.Runtime.Versioning.SupportedOSPlatform" Condition="!$(TargetFramework.StartsWith('netstandard'))">

pkg/Microsoft.Dotnet.WinForms.ProjectTemplates/content/WinFormsApplication-VisualBasic/ApplicationEvents.vb

@@ -3,15 +3,18 @@
 Namespace My
     ' The following events are available for MyApplication:
     ' Startup: Raised when the application starts, before the startup form is created.
-    ' Shutdown: Raised after all application forms are closed. This event is not raised if the application terminates abnormally.
+    ' Shutdown: Raised after all application forms are closed. This event is not raised if the
+    '           application terminates abnormally.
     ' UnhandledException: Raised if the application encounters an unhandled exception.
     ' StartupNextInstance: Raised when launching a single-instance application and the application is already active.
     ' NetworkAvailabilityChanged: Raised when the network connection is connected or disconnected.
 
-    ' **NEW** ApplyApplicationDefaults: Raised when the application queries default values to be set for the application.
+    ' **NEW** ApplyApplicationDefaults:
+    ' Raised when the application queries default values to be set for the application.
 
     ' Example:
-    ' Private Sub MyApplication_ApplyApplicationDefaults(sender As Object, e As ApplyApplicationDefaultsEventArgs) Handles Me.ApplyApplicationDefaults
+    ' Private Sub MyApplication_ApplyApplicationDefaults(sender As Object, e As ApplyApplicationDefaultsEventArgs) _
+    '    Handles Me.ApplyApplicationDefaults
     '
     '   ' Setting the application-wide default Font:
     '   e.Font = New Font(FontFamily.GenericSansSerif, 12, FontStyle.Regular)

src/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj

@@ -18,6 +18,10 @@
     <UsePublicApiAnalyzers>true</UsePublicApiAnalyzers>
   </PropertyGroup>
 
+  <ItemGroup>
+    <Compile Remove="Microsoft\VisualBasic\MyServices\Internal\WebClientCopy.vb" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\..\System.Windows.Forms\src\System.Windows.Forms.csproj" />
   </ItemGroup>

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/ApplicationBase.vb

@@ -16,7 +16,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         ' The executing application (the EntryAssembly)
         Private _info As AssemblyInfo
 
-        'Lazy-initialized and cached log object.
+        ' Lazy-initialized and cached log object.
         Private _log As Logging.Log
 
         Public Sub New()
@@ -38,7 +38,9 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         Public ReadOnly Property Info() As AssemblyInfo
             Get
                 If _info Is Nothing Then
-                    Dim assembly As Reflection.Assembly = If(Reflection.Assembly.GetEntryAssembly(), Reflection.Assembly.GetCallingAssembly())
+                    Dim assembly As Reflection.Assembly =
+                        If(Reflection.Assembly.GetEntryAssembly(), Reflection.Assembly.GetCallingAssembly())
+
                     _info = New AssemblyInfo(assembly)
                 End If
                 Return _info

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/CantStartSingleInstanceException.vb

@@ -2,6 +2,7 @@
 ' The .NET Foundation licenses this file to you under the MIT license.
 
 Imports System.ComponentModel
+Imports System.Runtime.Serialization
 
 Imports VbUtils = Microsoft.VisualBasic.CompilerServices.ExceptionUtils
 
@@ -18,7 +19,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         ' Deserialization constructor must be defined since we are serializable
         <EditorBrowsable(EditorBrowsableState.Advanced)>
         <Obsolete("Type or member is obsolete", DiagnosticId:="SYSLIB0051")>
-        Protected Sub New(info As Runtime.Serialization.SerializationInfo, context As Runtime.Serialization.StreamingContext)
+        Protected Sub New(info As SerializationInfo, context As StreamingContext)
             MyBase.New(info, context)
         End Sub
 

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/ConsoleApplicationBase.vb

@@ -50,14 +50,28 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         Public ReadOnly Property CommandLineArgs() As ObjectModel.ReadOnlyCollection(Of String)
             Get
                 If _commandLineArgs Is Nothing Then
-                    'Get rid of Arg(0) which is the path of the executing program. Main(args() as string) doesn't report the name of the app and neither will we
+                    ' Get rid of Arg(0) which is the path of the executing program. Main(args() as string)
+                    ' doesn't report the name of the app and neither will we
                     Dim envArgs As String() = Environment.GetCommandLineArgs
-                    If envArgs.GetLength(0) >= 2 Then '1 element means no args, just the executing program. >= 2 means executing program + one or more command line arguments
-                        Dim newArgs(envArgs.GetLength(0) - 2) As String 'dimming z(0) gives a z() of 1 element.
-                        Array.Copy(envArgs, 1, newArgs, 0, envArgs.GetLength(0) - 1) 'copy everything but the 0th element (the path of the executing program)
+
+                    ' 1 element means no args, just the executing program.
+                    If envArgs.GetLength(0) >= 2 Then
+                        ' >= 2 means executing program + one or more command line arguments
+                        ' dimming z(0) gives a z() of 1 element.
+                        Dim newArgs(envArgs.GetLength(0) - 2) As String
+
+                        ' Copy everything but the 0th element (the path of the executing program)
+                        Dim length As Integer = envArgs.GetLength(0) - 1
+                        Array.Copy(
+                            sourceArray:=envArgs,
+                            sourceIndex:=1,
+                            destinationArray:=newArgs,
+                            destinationIndex:=0,
+                            length)
                         _commandLineArgs = New ObjectModel.ReadOnlyCollection(Of String)(newArgs)
                     Else
-                        _commandLineArgs = New ObjectModel.ReadOnlyCollection(Of String)(Array.Empty(Of String)())  'provide the empty set
+                        ' Provide the empty set
+                        _commandLineArgs = New ObjectModel.ReadOnlyCollection(Of String)(Array.Empty(Of String)())
                     End If
                 End If
                 Return _commandLineArgs

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/NoStartupFormException.vb

@@ -2,6 +2,7 @@
 ' The .NET Foundation licenses this file to you under the MIT license.
 
 Imports System.ComponentModel
+Imports System.Runtime.Serialization
 
 Imports VbUtils = Microsoft.VisualBasic.CompilerServices.ExceptionUtils
 
@@ -17,7 +18,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         ' De-serialization constructor must be defined since we are serializable
         <EditorBrowsable(EditorBrowsableState.Advanced)>
         <Obsolete("Type or member obsolete.", DiagnosticId:="SYSLIB0051")>
-        Protected Sub New(info As Runtime.Serialization.SerializationInfo, context As Runtime.Serialization.StreamingContext)
+        Protected Sub New(info As SerializationInfo, context As StreamingContext)
             MyBase.New(info, context)
         End Sub
 

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/User.vb

@@ -71,7 +71,9 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         '''  Indicates whether or not the current user is a member of the passed in role.
         ''' </summary>
         ''' <param name="role">The name of the role.</param>
-        ''' <returns><see langword="True"/> if the user is a member of the role otherwise <see langword="False"/>.</returns>
+        ''' <returns>
+        '''  <see langword="True"/> if the user is a member of the role otherwise <see langword="False"/>.
+        ''' </returns>
         Public Function IsInRole(role As String) As Boolean
             Return InternalPrincipal.IsInRole(role)
         End Function

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/WindowsFormsApplicationBase.vb

@@ -305,10 +305,14 @@ Namespace Microsoft.VisualBasic.ApplicationServices
             End Get
             Set(value As Form)
                 If value Is Nothing Then
-                    Throw VbUtils.GetArgumentNullException("MainForm", SR.General_PropertyNothing, "MainForm")
+                    Throw VbUtils.GetArgumentNullException(
+                        argumentName:="MainForm",
+                        resourceKey:=SR.General_PropertyNothing,
+                        "MainForm")
                 End If
                 If value Is _splashScreen Then
-                    Throw New ArgumentException(VbUtils.GetResourceString(SR.AppModel_SplashAndMainFormTheSame))
+                    Dim message As String = VbUtils.GetResourceString(SR.AppModel_SplashAndMainFormTheSame)
+                    Throw New ArgumentException(message)
                 End If
                 _appContext.MainForm = value
             End Set
@@ -480,7 +484,8 @@ Namespace Microsoft.VisualBasic.ApplicationServices
                         Try
                             If handler IsNot Nothing Then handler.Invoke(sender, e)
                         Catch ex As Exception
-                            If Not OnUnhandledException(New UnhandledExceptionEventArgs(True, ex)) Then
+                            Dim e1 As New UnhandledExceptionEventArgs(exitApplication:=True, exception:=ex)
+                            If Not OnUnhandledException(e1) Then
 
                                 ' The user didn't write a handler so throw the error up the chain.
                                 Throw
@@ -497,7 +502,8 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         '''  it doesn't freeze up while the main form is getting it together.
         ''' </summary>
         Private Sub DisplaySplash()
-            Debug.Assert(_splashScreen IsNot Nothing, "We should have never get here if there is no splash screen")
+            Const Message As String = "We should have never get here if there is no splash screen"
+            Debug.Assert(_splashScreen IsNot Nothing, Message)
 
             If _splashTimer IsNot Nothing Then
 
@@ -538,13 +544,15 @@ Namespace Microsoft.VisualBasic.ApplicationServices
                     ' have already seen via our hook of System.Windows.Forms.Application.ThreadException).
                     If _processingUnhandledExceptionEvent Then
 
-                        ' If the UnhandledException handler threw for some reason, throw that error out to the system.
+                        ' If the UnhandledException handler threw for some reason,
+                        ' throw that error out to the system.
                         Throw
                     Else
 
                         ' We had an exception, but not during the OnUnhandledException handler so give the user
                         ' a chance to look at what happened in the UnhandledException event handler
-                        If Not OnUnhandledException(New UnhandledExceptionEventArgs(True, ex)) Then
+                        Dim e As New UnhandledExceptionEventArgs(exitApplication:=True, ex)
+                        If Not OnUnhandledException(e) Then
 
                             ' The user didn't write a handler so throw the error out to the system
                             Throw
@@ -668,7 +676,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         '''  <see cref="UnhandledException"/> event so we do the translation here before raising our event.
         ''' </remarks>
         Private Sub OnUnhandledExceptionEventAdaptor(sender As Object, e As ThreadExceptionEventArgs)
-            OnUnhandledException(New UnhandledExceptionEventArgs(True, e.Exception))
+            OnUnhandledException(New UnhandledExceptionEventArgs(exitApplication:=True, e.Exception))
         End Sub
 
         ''' <summary>
@@ -796,7 +804,9 @@ Namespace Microsoft.VisualBasic.ApplicationServices
 #Enable Warning WFO5001
 
             ' We'll handle "/nosplash" for you.
-            If Not (commandLineArgs.Contains("/nosplash") OrElse Me.CommandLineArgs.Contains("-nosplash")) Then
+            If Not (commandLineArgs.Contains("/nosplash") OrElse
+                Me.CommandLineArgs.Contains("-nosplash")) Then
+
                 ShowSplashScreen()
             End If
 
@@ -1016,7 +1026,10 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         ''' <param name="value"></param>
         Friend Shared Sub ValidateAuthenticationModeEnumValue(value As AuthenticationMode, paramName As String)
             If value < AuthenticationMode.Windows OrElse value > AuthenticationMode.ApplicationDefined Then
-                Throw New InvalidEnumArgumentException(paramName, value, GetType(AuthenticationMode))
+                Throw New InvalidEnumArgumentException(
+                    argumentName:=paramName,
+                    invalidValue:=value,
+                    enumClass:=GetType(AuthenticationMode))
             End If
         End Sub
 
@@ -1026,7 +1039,10 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         ''' <param name="value"></param>
         Friend Shared Sub ValidateShutdownModeEnumValue(value As ShutdownMode, paramName As String)
             If value < ShutdownMode.AfterMainFormCloses OrElse value > ShutdownMode.AfterAllFormsClose Then
-                Throw New InvalidEnumArgumentException(paramName, value, GetType(ShutdownMode))
+                Throw New InvalidEnumArgumentException(
+                    argumentName:=paramName,
+                    invalidValue:=value,
+                    enumClass:=GetType(ShutdownMode))
             End If
         End Sub