Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GivenThatWeWantToRunILLink test class into multiple so Helix can run them separately #44973

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Nov 20, 2024

Fixes #44895

Durations from this PR:

Durations from a random other PR (#44968):

}

internal static class ILLinkTestUtils
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the utility functions in the same file to minimize the diff but let me know if I should move it to a separate file

Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@akoeplinger akoeplinger merged commit d691b06 into dotnet:main Nov 20, 2024
38 checks passed
@akoeplinger akoeplinger deleted the split-illink-tests branch November 20, 2024 20:44
@joeloff
Copy link
Member

joeloff commented Nov 23, 2024

/backport to release/9.0.2xx

Copy link
Contributor

Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/11982499885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ILLink untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.NET.Publish.Tests.dll.5 is timing out a lot, imbalance with other partitions
4 participants