Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the LLVM-AOT build failure occuring around SN_IsNormal #111559

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

tannergooding
Copy link
Member

This was introduced in #111179 and is occurring because emit_not_xequal returns a bool not a vector

Copy link
Contributor

Tagging subscribers to this area: @steveisok, @vitek-karas
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lateralusX
Copy link
Member

I see that the same intrinsic was added to interpreter using the same emit_not_xequal, should it be changed there as well?

@tannergooding
Copy link
Member Author

@lateralusX what change are you referring to?

The mono interpreter had one file changed, which was to handle the new ShiftLeft overload (due to a bad assumption): https://github.com/dotnet/runtime/pull/111179/files#diff-46cef4f4256ed29f631e64fee27f12bd8a2c126fa465243f8651df322c422e56

The other changes were all to the shared simd-intrinsics of which this was the only emit_not_xequal change: https://github.com/dotnet/runtime/pull/111179/files#diff-012b47a27abc5dbc9d2a0b6fdef4adec27fa207a7d2b53823a8bc80f6539f5af

The interpreter work and some of the main Mono work was deferred as it required a more complex refactoring to expose some shared helpers for commonly reused IR. -- I'm almost done with that work and should have a PR up later this week.

@lateralusX
Copy link
Member

@lateralusX what change are you referring to?

The mono interpreter had one file changed, which was to handle the new ShiftLeft overload (due to a bad assumption): https://github.com/dotnet/runtime/pull/111179/files#diff-46cef4f4256ed29f631e64fee27f12bd8a2c126fa465243f8651df322c422e56

The other changes were all to the shared simd-intrinsics of which this was the only emit_not_xequal change: https://github.com/dotnet/runtime/pull/111179/files#diff-012b47a27abc5dbc9d2a0b6fdef4adec27fa207a7d2b53823a8bc80f6539f5af

The interpreter work and some of the main Mono work was deferred as it required a more complex refactoring to expose some shared helpers for commonly reused IR. -- I'm almost done with that work and should have a PR up later this week.

Sorry, looks like the GitHub UI tricked me when I displayed the diff of the change in #111179, I clicked on the transform_simd.c but showed parts of the change in simd_intrinsics.c.

Change in this PR LGTM!

@tannergooding tannergooding merged commit ceb1a01 into dotnet:main Jan 21, 2025
99 of 106 checks passed
@tannergooding tannergooding deleted the fix-103845 branch January 21, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants