-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve the LLVM-AOT build failure occuring around SN_IsNormal #111559
Conversation
Tagging subscribers to this area: @steveisok, @vitek-karas |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
I see that the same intrinsic was added to interpreter using the same emit_not_xequal, should it be changed there as well? |
@lateralusX what change are you referring to? The mono interpreter had one file changed, which was to handle the new ShiftLeft overload (due to a bad assumption): https://github.com/dotnet/runtime/pull/111179/files#diff-46cef4f4256ed29f631e64fee27f12bd8a2c126fa465243f8651df322c422e56 The other changes were all to the shared The interpreter work and some of the main Mono work was deferred as it required a more complex refactoring to expose some shared helpers for commonly reused IR. -- I'm almost done with that work and should have a PR up later this week. |
Sorry, looks like the GitHub UI tricked me when I displayed the diff of the change in #111179, I clicked on the transform_simd.c but showed parts of the change in simd_intrinsics.c. Change in this PR LGTM! |
This was introduced in #111179 and is occurring because
emit_not_xequal
returns abool
not avector