Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][globalization] Revert of #107390 to allow the use of String.Replace #111534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Jan 17, 2025

Reverting #107390 to unblock MAUI upgrade to .NET 10 #111506.

Note that this will cause IndexOf, in some cases, to return incorrect matchLength due to normalization we use before calling Objective-C rangeOfString API.

We will investigate this further to implement a proper fix:

  • Identify scenarios when IndexOf doesn't work correctly (doesn't find match or reports incorrect matchLength)
  • Investigate Objective-C APIs to see if we can get away without normalizing strings

Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@matouskozak
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant