Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Use any reaching def for unreachable uses in incremental SSA builder #110077

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Nov 22, 2024

Also give unreachable stores an SSA number.

Fix #109971

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 22, 2024
…lder

Also give unreachable stores an SSA number.

Fix dotnet#109971
@jakobbotsch jakobbotsch changed the title JIT: Use any reaching def for unreachable uses JIT: Use any reaching def for unreachable uses in incremental SSA builder Nov 22, 2024
@jakobbotsch jakobbotsch marked this pull request as ready for review November 25, 2024 12:54
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @EgorBo

There really is no correct reaching definition in this case, so any reaching definition will do here. This matches what happens normally in the JIT when various phases optimize control flow after SSA has been built without removing the now-unreachable blocks.

Diffs. They happen because we now create some more assertions for these uses which push out other assertions.

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

They happen because we now create some more assertions for these uses which push out other assertions.

I wonder if we should only accept the most profitable assertions if we already consumed 80% of the budget

@jakobbotsch
Copy link
Member Author

I wonder if we should only accept the most profitable assertions if we already consumed 80% of the budget

Sounds like a good idea.. Or we should look into why we cannot just allow more assertions through.

@jakobbotsch jakobbotsch merged commit 0170d78 into dotnet:main Nov 26, 2024
105 of 108 checks passed
@jakobbotsch jakobbotsch deleted the fix-109971 branch November 26, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuzzlyn: Assertion failed '!m_compiler->lvaInSsa(tree->GetLclNum())' during 'Assertion prop'
2 participants