Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Fix IL2104 link #108533

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 3, 2024

Backport of #106895 to release/9.0

/cc @sbomer

Customer Impact

  • Customer reported
  • Found internally

Found internally in code review: https://github.com/dotnet/docs/pull/29837/files#r897416503. Later reported by customer who wanted more detail about the IL2104 warning, and didn't find their way to https://learn.microsoft.com/dotnet/core/deploying/trimming/trim-warnings/il2104.

Regression

  • No

Testing

Validated that the new warning message contains the updated text.

Risk

Low. Only changes the warning text to point to a new link.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Oct 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Oct 3, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please get a code review. we will take for consideration in 9 GA

@jeffschwMSFT jeffschwMSFT added this to the 9.0.0 milestone Oct 4, 2024
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will help the experience.

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 8, 2024
@jeffschwMSFT jeffschwMSFT merged commit ae7f3a4 into release/9.0 Oct 9, 2024
13 of 72 checks passed
@jkotas jkotas deleted the backport/pr-106895-to-release/9.0 branch October 10, 2024 07:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants