-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] Fix IL2104 link #108533
[release/9.0] Fix IL2104 link #108533
Conversation
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please get a code review. we will take for consideration in 9 GA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This will help the experience.
Backport of #106895 to release/9.0
/cc @sbomer
Customer Impact
Found internally in code review: https://github.com/dotnet/docs/pull/29837/files#r897416503. Later reported by customer who wanted more detail about the IL2104 warning, and didn't find their way to https://learn.microsoft.com/dotnet/core/deploying/trimming/trim-warnings/il2104.
Regression
Testing
Validated that the new warning message contains the updated text.
Risk
Low. Only changes the warning text to point to a new link.