Weaken assert around folding constants #103026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this assert with native AOT. It seems to be too strong - we are not allowed to fold IconHandle constants with prejit.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
approved these changes
Jun 4, 2024
|
/ba-g Infrastructure timeout that the infra paired with #102239. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this assert with native AOT. It seems to be too strong - we are not allowed to fold IconHandle constants with prejit so this feels expected for that.
The test that runs into this is handleMath.ilproj from the pri 1 test suite. We don't currently run pri1 suite with native AOT, I'm in the process of unblocking it.
Cc @dotnet/ilc-contrib
@dotnet/jit-contrib PTAL