Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for emitting string literals into data section as UTF8 #76036

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Add feature flag for emitting string literals into data section as UTF8

43aa343
Select commit
Loading
Failed to load commit list.
Draft

Add feature flag for emitting string literals into data section as UTF8 #76036

Add feature flag for emitting string literals into data section as UTF8
43aa343
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Nov 23, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Build Failures

roslyn-CI / Unix_Debug_CoreClr / Test_Linux_Debug / Test

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌Bash failed with error: 1
    ❌Bash exited with return code: 1

Test Failures (2 tests failed)

🔹 [All failing tests from roslyn-CI]

    Microsoft.CodeAnalysis.CSharp.CommandLine.UnitTests_Microsoft.CodeAnalysis.CSharp.Emit.UnitTests_0.WorkItemExecution [Console] [Details] [Artifacts] [1.29% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
    This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

    Failing Configuration

    Microsoft.CodeAnalysis.CSharp.UnitTests.EmitMetadata.Utf8StringEncoding_SynthesizedTypes [Console] [Details] [Artifacts] [22.22% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configuration

    Exception Message
    Expected:
    .class private auto ansi sealed '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'
    	extends [mscorlib]System.Object
    {
    	.custom instance void [mscorlib]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = (
    		01 00 00 00
    	)
    	// Fields
    	.field assembly static initonly valuetype '<PrivateImplementationDetails>'/'__StaticArrayInitTypeSize=5' f at I_00002830
    	.data cil I_00002830 = bytearray (
    		48 65 6c 6c 6f
    ... truncated ...
    Actual:
    .class private auto ansi sealed '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'
    	extends [mscorlib]System.Object
    {
    	.custom instance void [mscorlib]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = (
    		01 00 00 00
    	)
    	// Fields
    	.field assembly static initonly valuetype '<PrivateImplementationDetails>'/'__StaticArrayInitTypeSize=5' f at I_00002878
    	.data cil I_00002878 = bytearray (
    		48 65 6c 6c 6f
    	)
    	.field assembly static initonly string s
    	// Methods
    	.method private hidebysig specialname rtspecialname static 
    		void .cctor () cil managed 
    	{
    		// Method begins at RVA 0x2089
    		// Code size 17 (0x11)
    		.maxstack 8
    		IL_0000: ldsflda valuetype '<PrivateImplementationDetails>'/'__StaticArrayInitTypeSize=5' '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'::f
    		IL_0005: ldc.i4.5
    		IL_0006: call string '<PrivateImplementationDetails>'::BytesToString(uint8*, int32)
    		IL_000b: stsfld string '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'::s
    		IL_0010: ret
    	} // end of method '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'::.cctor
    } // end of class <S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969
    Differences:
        .class private auto ansi sealed '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'
        	extends [mscorlib]System.Object
        {
        	.custom instance void [mscorlib]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = (
        		01 00 00 00
        	)
        	// Fields
    ++> 	.field assembly static initonly valuetype '<PrivateImplementationDetails>'/'__StaticArrayInitTypeSize=5' f at I_00002878
    ++> 	.data cil I_00002878 = bytearray (
    --> 	.field assembly static initonly valuetype '<PrivateImplementationDetails>'/'__StaticArrayInitTypeSize=5' f at I_00002830
    --> 	.data cil I_00002830 = bytearray (
        		48 65 6c 6c 6f
        	)
        	.field assembly static initonly string s
        	// Methods
        	.method private hidebysig specialname rtspecialname static 
        		void .cctor () cil managed 
        	{
        		// Method begins at RVA 0x2089
        		// Code size 17 (0x11)
        		.maxstack 8
        		IL_0000: ldsflda valuetype '<PrivateImplementationDetails>'/'__StaticArrayInitTypeSize=5' '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'::f
        		IL_0005: ldc.i4.5
        		IL_0006: call string '<PrivateImplementationDetails>'::BytesToString(uint8*, int32)
        		IL_000b: stsfld string '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'::s
        		IL_0010: ret
        	} // end of method '<S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969'::.cctor
        } // end of class <S>185F8DB32271FE25F561A6FC938B2E264306EC304EDA518007D1764826381969
    
    CallStack
       at Roslyn.Test.Utilities.AssertEx.AssertEqualToleratingWhitespaceDifferences(String expected, String actual, String message, Boolean escapeQuotes, String expectedValueSourcePath, Int32 expectedValueSourceLine) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 578
       at Microsoft.CodeAnalysis.Test.Utilities.CompilationVerifier.<>c__DisplayClass19_0.<VerifyTypeIL>b__0(String output) in /_/src/Compilers/Test/Core/CompilationVerifier.cs:line 197
       at Microsoft.CodeAnalysis.Test.Utilities.CompilationVerifier.VerifyTypeIL(String typeName, Action`1 validateExpected) in /_/src/Compilers/Test/Core/CompilationVerifier.cs:line 254
       at Microsoft.CodeAnalysis.Test.Utilities.CompilationVerifier.VerifyTypeIL(String typeName, String expected) in /_/src/Compilers/Test/Core/CompilationVerifier.cs:line 188
       at Microsoft.CodeAnalysis.CSharp.UnitTests.EmitMetadata.Utf8StringEncoding_SynthesizedTypes() in /_/src/Compilers/CSharp/Test/Emit/Emit/EmitMetadataTests.cs:line 3077
       at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
       at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Was this helpful? Yes No