Fixes #10633 - multiple statements simplified by removing explicit comparison #10698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-bot agree |
|
@dotnet-policy-service agree |
gewarren
reviewed
Nov 21, 2024
| @@ -76,7 +76,7 @@ int main(array<String^>^ args) | |||
| String^ answer = Console::ReadLine(); | |||
| // If the user canceled the send, and mail hasn't been | |||
| // sent yet,then cancel the pending operation. | |||
| if (answer->ToLower()->StartsWith("c") && mailSent == false) | |||
| if (!answer->ToLower()->StartsWith("c") && mailSent) | |||
There was a problem hiding this comment.
Suggested change
| if (!answer->ToLower()->StartsWith("c") && mailSent) | |
| if (!(answer->ToLower()->StartsWith("c") && mailSent)) |
| @@ -2269,7 +2269,7 @@ jQuery.event = { | |||
| elem = window; | |||
| } | |||
|
|
|||
| if ( handler === false ) { | |||
| if (! handler) { | |||
There was a problem hiding this comment.
Suggested change
| if (! handler) { | |
| if (!handler) { |
| @@ -2416,7 +2416,7 @@ jQuery.event = { | |||
| return; | |||
| } | |||
|
|
|||
| if ( handler === false ) { | |||
| if (! handler) { | |||
There was a problem hiding this comment.
Suggested change
| if (! handler) { | |
| if (!handler) { |
| @@ -2713,7 +2713,7 @@ jQuery.event = { | |||
|
|
|||
| if ( ret !== undefined ) { | |||
| event.result = ret; | |||
| if ( ret === false ) { | |||
| if (! ret) { | |||
There was a problem hiding this comment.
Suggested change
| if (! ret) { | |
| if (!ret) { |
| maxLevel = match.level; | ||
|
|
||
| if ( ret === false ) { | ||
| if (! ret) { |
There was a problem hiding this comment.
Suggested change
| if (! ret) { | |
| if (!ret) { |
| @@ -6714,7 +6714,7 @@ jQuery.extend({ | |||
| } | |||
|
|
|||
| // Set the correct header, if data is being sent | |||
| if ( s.data && s.hasContent && s.contentType !== false || options.contentType ) { | |||
| if ( s.data && s.hasContent && !s.contentType || options.contentType ) { | |||
There was a problem hiding this comment.
Suggested change
| if ( s.data && s.hasContent && !s.contentType || options.contentType ) { | |
| if ( s.data && s.hasContent && s.contentType || options.contentType ) { |
| @@ -7051,7 +7051,7 @@ jQuery.ajaxPrefilter( "json jsonp", function( s, originalSettings, jqXHR ) { | |||
| if ( s.dataTypes[ 0 ] === "jsonp" || | |||
| originalSettings.jsonpCallback || | |||
| originalSettings.jsonp != null || | |||
| s.jsonp !== false && ( jsre.test( s.url ) || | |||
| !s.jsonp && ( jsre.test( s.url ) || | |||
There was a problem hiding this comment.
Suggested change
| !s.jsonp && ( jsre.test( s.url ) || | |
| s.jsonp && ( jsre.test( s.url ) || |
| @@ -3459,7 +3459,7 @@ $.widget("ui.sortable", $.ui.mouse, { | |||
|
|
|||
| } | |||
|
|
|||
| if(scrolled !== false && $.ui.ddmanager && !o.dropBehaviour) | |||
| if(!scrolled && $.ui.ddmanager && !o.dropBehaviour) | |||
There was a problem hiding this comment.
Suggested change
| if(!scrolled && $.ui.ddmanager && !o.dropBehaviour) | |
| if(scrolled && $.ui.ddmanager && !o.dropBehaviour) |
| @@ -5168,7 +5168,7 @@ $.widget( "ui.autocomplete", { | |||
| } | |||
|
|
|||
| clearTimeout( this.closing ); | |||
| if ( this._trigger( "search", event ) === false ) { | |||
| if (! this._trigger( "search", event )) { | |||
There was a problem hiding this comment.
Suggested change
| if (! this._trigger( "search", event )) { | |
| if (!this._trigger( "search", event )) { |
There was a problem hiding this comment.
Can you also remove the other spaces like this in this file?
| @@ -309,7 +309,7 @@ Sys.Mvc.MvcHelpers._onComplete = function Sys_Mvc_MvcHelpers$_onComplete(request | |||
| /// <param name="ajaxContext" type="Sys.Mvc.AjaxContext"> | |||
| /// </param> | |||
| ajaxContext.set_response(request.get_executor()); | |||
| if (ajaxOptions.onComplete && ajaxOptions.onComplete(ajaxContext) === false) { | |||
| if (!ajaxOptions.onComplete && ajaxOptions.onComplete(ajaxContext)) { | |||
There was a problem hiding this comment.
Suggested change
| if (!ajaxOptions.onComplete && ajaxOptions.onComplete(ajaxContext)) { | |
| if (!(ajaxOptions.onComplete && ajaxOptions.onComplete(ajaxContext))) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Multiple if and while statements simplified by removing explicit comparison and replacing with logical NOT operator as required.
Fixes #10633