Update startup time guidance to not recommend BinaryFormatter #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
okr-health
gewarren
approved these changes
Nov 12, 2024
dotnet-desktop-guide/framework/wpf/advanced/application-startup-time.md
Outdated
Show resolved
Hide resolved
|
Ahh OK I went to the page. |
…p-time.md Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the Startup Time guidance to not recommend using BinaryFormatter. Instead, recommend using the XML Serializer Generator tool (Sgen.exe) for better performance.
I searched through this repo and the only other references I saw to BinaryFormatter are resource files from the samples that indicate data was serialized using BinaryFormatter into the resources. That's probably OK to keep.
Fixes #1551
Internal previews