Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binding validation path #1916

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fix binding validation path #1916

merged 4 commits into from
Oct 29, 2024

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Oct 25, 2024 •
edited by github-actions bot
Loading

Summary

  • Adjust binding path style for the tooltip.
  • VS auto upgraded projects to .NET 4.8.
  • Trimmed the data object.
  • Added the data object to the article.

Fixes #1878

Internal previews

📄 File 🔗 Preview link
dotnet-desktop-guide/framework/wpf/data/how-to-implement-binding-validation.md dotnet-desktop-guide/framework/wpf/data/how-to-implement-binding-validation

@adegeo adegeo requested a review from BillWagner October 28, 2024 18:34
@adegeo
Copy link
Contributor Author

adegeo commented Oct 28, 2024

@BillWagner Ready!

BillWagner
BillWagner approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@adegeo adegeo merged commit 670d3b5 into main Oct 29, 2024
6 checks passed
@adegeo adegeo deleted the style-1878 branch October 29, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-framework/svc wpf/subsvc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback: Better way to style the tooltip
2 participants
@adegeo @BillWagner