Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Class1.cs #1907

Closed
wants to merge 1 commit into from
Closed

Conversation

bigboybamo
Copy link
Contributor

Summary

Add C# Using statement for PrivateFontCollection

Fixes #Issue_Number #1872

@adegeo
Copy link
Contributor

adegeo commented Oct 9, 2024

Hi @bigboybamo Thank you for the submission. Unfortunately this old code is missing a project file too, so our automation will flag this as incomplete, but just looking at the submission I spotted that you forgot to put in a closing }. Also, all of these articles have Visual Basic support so the code for Visual Basic needs to be updated too.

Did you run this through Visual Studio or just edit the file in GitHub? It's important to get the code to compile in Visual Studio before submitting updates.

If you would like to start contributing to fixing different bugs, I can find some more and assign them to you.

@bigboybamo
Copy link
Contributor Author

Hi @adegeo Yes, I took the code to VS to make sure there were no errors but I did not compile the code.
Yes you can assign some to me, happy to help.

@adegeo
Copy link
Contributor

adegeo commented Oct 24, 2024

Hi @bigboybamo I'm going to close this in favor of the one I just opened up. There were actually 6 or so different objects that needed to be disposed (each Font object created). So I decided to rewrite the code completely. I was able to trim around 50 lines out of it and make it much simpler.

I'll make some time to find some things to assign to you in the future. Do you only work on WinForms? Can you do VB? Can you do WPF? Let me know, thanks!

@adegeo adegeo closed this Oct 24, 2024
@bigboybamo
Copy link
Contributor Author

Hi @adegeo
Thanks for letting me know.
I mostly do winforms but I’m open to WPF as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants