Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify WPF metadata return type #1694

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Clarify WPF metadata return type #1694

merged 2 commits into from
Sep 1, 2023

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Sep 1, 2023 •
edited
Loading

Summary

  • Moved the snippets for the index article to the index folder
  • Added new snippet to demonstrate casting the metadata return type
  • Updated article with text related to the metadata return type and added the snippet.

Fixes #1690

Here is a direct link to the section with the modified text and the TwoWay bullet point is where the modifications are.

Internal previews

📄 File 🔗 Preview link
dotnet-desktop-guide/net/wpf/data/index.md Data binding overview (WPF .NET)

@adegeo adegeo requested a review from CamSoper September 1, 2023 19:00
@adegeo adegeo changed the title Clarify WPF metdata return type Clarify WPF metadata return type Sep 1, 2023
CamSoper
CamSoper approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adegeo adegeo merged commit 9b56103 into main Sep 1, 2023
6 checks passed
@adegeo adegeo deleted the 1690-metadata branch September 1, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamSoper CamSoper CamSoper approved these changes

Assignees
No one assigned
Labels
dotnet-desktop/svc wpf/subsvc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetMetadata returns UIPropertyMetadata, is this then OneWay binding?
3 participants
@adegeo @CamSoper @dotnet-bot