Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update style for the .defaultHidden to resolve Bug: #6750 #6778

Closed
wants to merge 1 commit into from

Conversation

D34NM
Copy link

@D34NM D34NM commented Nov 24, 2024

Description

The fix is a simple CSS style change. The style for the .defaultHidden class was applied on the "layer" above the actual menu item.

image

Fixes # (issue)

Bug #6750

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 24, 2024
@JamesNK
Copy link
Member

JamesNK commented Nov 24, 2024

This is incorrect. The ... button should only be visible when hovering over the grid value.

I can't reproduce the reported issue: #6750 (comment)

cc @mitchdenny

@D34NM
Copy link
Author

D34NM commented Nov 25, 2024

@JamesNK wasn't aware of it. But I could reproduce the issue described above. And it was visible, but I will close the PR. Thanks for the review :)

@D34NM D34NM closed this Nov 25, 2024
@D34NM D34NM deleted the fix/update-style-for-menu branch November 25, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants