-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RabbitMQ.Client v7 client integration package #6770
base: main
Are you sure you want to change the base?
Conversation
So from now on, folks that want to use latest will need to pick package named v7, and to use a future v8 rabbitmq they'll need to pick the package named v7 as well. So we have the v7 name indefinitely, if I understand right. Is it worth instead the breaking change to do the reverse, freeze the existing package renaming it v6? |
See #3956 for the strategy to deal with these breaking changes. |
Yeah I already read that and I was confused so I asked 🙂
I don't think this change did this?
We didn't do this either. What am I missing? |
At the time that issue was written (in April), we were assuming RabbitMQ.Client v7 would ship before .NET Aspire 9. The general strategy is "on the next major version of .NET Aspire". So we will do the "swap" when .NET Aspire 10 ships since RabbitMQ.Client v7 and .NET Aspire 9 shipped at basically the same time.
This would be done at the time of the "swap" (i.e. .NET Aspire 10) if RabbitMQ.Client v6 is still in support and used by customers. |
#if RABBITMQ_V6 | ||
RabbitMqClientEventSource.Log.Info(message); | ||
#else | ||
s_log.GetType().GetMethod("Info")!.Invoke(s_log, new object[] { message }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth caching these methodinfos, or is this pattern nearly equivalently fast these days with internal caching? @steveharter
Description
RabbitMQ.Client shipped a version
7.0.0
that has major breaking changes. Specifically, it removed all sync APIs and only contain async APIs. To continue supporting new versions of RabbitMQ.Client, we need to add a new componentAspire.RabbitMQ.Client.v7
that will work with the new version of RabbitMQ.Client. See #3956 for the strategy to deal with these breaking changes.Fix #3956
Checklist
<remarks />
and<code />
elements on your triple slash comments?doc-idea
template):Microsoft Reviewers: Open in CodeFlow