-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut over to aspire-9.0 schema. #6596
base: main
Are you sure you want to change the base?
Conversation
@@ -5,5 +5,5 @@ namespace Aspire.Hosting.Utils; | |||
|
|||
internal static class SchemaUtils | |||
{ | |||
public const string SchemaVersion = "https://json.schemastore.org/aspire-8.0.json"; | |||
public const string SchemaVersion = "https://json.schemastore.org/aspire-9.0.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go into the release/9.0 branch for our first servicing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to discuss strategy here with @davidfowl, @vhvb1989, and @ellismg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate that using the 9.0.0 bits today, can produce a manifest that doesn't conform to the schema it says it conforms to. For example:
- Call the
PublishAsAzureContainerApp
method - This will produce a manifest that points to
https://json.schemastore.org/aspire-8.0.json
and also hasproject.v1
, which isn't valid for that schema version.
Our playground app does this today:
aspire/playground/AzureContainerApps/AzureContainerApps.AppHost/aspire-manifest.json
Line 2 in 11c51e7
"$schema": "https://json.schemastore.org/aspire-8.0.json", |
aspire/playground/AzureContainerApps/AzureContainerApps.AppHost/aspire-manifest.json
Lines 105 to 106 in 11c51e7
"api": { | |
"type": "project.v1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah so there are two approaches we can take here. We can update the -8.0 schema on schema store with the one we have in our repo and just not bump the version, or we can ship a -9.0 schema and make sure it works everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd assume bumping the version is the "right" thing to do. It doesn't really make sense to add things and not change the version. Because what's the point of versioning it then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be done dynamically
Description
Updating the schema to aspire-9.0. Just a rename of everything.
Fixes #6581
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):