Configure OpenAI models in the app host #6577
Conversation
sebastienros
changed the title
src/Aspire.Hosting.Azure.CognitiveServices/AzureOpenAIConnectionResource.cs
Outdated
Show resolved
Hide resolved
| @@ -14,4 +14,3 @@ Aspire.Hosting.ApplicationModel.AzureOpenAIResource.Deployments.get -> System.Co | |||
| Aspire.Hosting.AzureOpenAIExtensions | |||
| static Aspire.Hosting.AzureOpenAIExtensions.AddAzureOpenAI(this Aspire.Hosting.IDistributedApplicationBuilder! builder, string! name) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.AzureOpenAIResource!>! | |||
| static Aspire.Hosting.AzureOpenAIExtensions.AddAzureOpenAI(this Aspire.Hosting.IDistributedApplicationBuilder! builder, string! name, System.Action<Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.AzureOpenAIResource!>!, Aspire.Hosting.ResourceModuleConstruct!, Azure.Provisioning.CognitiveServices.CognitiveServicesAccount!, System.Collections.Generic.IEnumerable<Azure.Provisioning.CognitiveServices.CognitiveServicesAccountDeployment!>!>? configureResource) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.AzureOpenAIResource!>! | |||
| static Aspire.Hosting.AzureOpenAIExtensions.AddDeployment(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.AzureOpenAIResource!>! builder, Aspire.Hosting.ApplicationModel.AzureOpenAIDeployment! deployment) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.ApplicationModel.AzureOpenAIResource!>! | |||
There was a problem hiding this comment.
Are we able to do this without making breaking changes? For example, can we obsolete something and add new APIs?
There was a problem hiding this comment.
I reverted as I didn't remember why the change was done. Do we want to keep AddDeployment or replaced it with WithDeployment?
src/Aspire.Hosting.Azure.CognitiveServices/AzureOpenAIConnectionResource.cs
Outdated
Show resolved
Hide resolved
playground/OpenAIEndToEnd/OpenAIEndToEnd.WebStory/Components/Pages/Home.razor
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.CognitiveServices/IHasDeploymentsResource.cs
Outdated
Show resolved
Hide resolved
|
Overall looks great. @eerhardt's point about the breaking change is probably the main thing to consider. Besides that it looks pretty close to being ready. |
SteveSandersonMS
force-pushed
the
stevesa/meai-integration
branch
from
4587b4b
to
a29740a
Compare
sebastienros
force-pushed
the
sebros/hostmodels
branch
from
14cec51
to
16a16a3
Compare
…ebros/hostmodels # Conflicts: # playground/OpenAIEndToEnd/OpenAIEndToEnd.WebStory/Program.cs # src/Components/Aspire.Azure.AI.OpenAI/AspireAzureOpenAIClientBuilderChatClientExtensions.cs # src/Components/Aspire.Azure.AI.OpenAI/PublicAPI.Unshipped.txt
|
I updated the PR. @SteveSandersonMS is this something we could merge in your PR as it's impacting how configuration is passed to the clients. Other option is I wait for your PR to be done and then react to the changes. |
|
@sebastienros I'm fine with it being merged into my PR, but my PR itself can't be completed until we get the next build of Microsoft.Extensions.AI, because the agreed API shape depends on API changes we've just merged into |
|
@eerhardt does it make sense to split this PR in two: the deployment API changes creating the ENVs, and the MEAI part that is using it and would be part of Steve's. Or just move everything to Steve's branch and ship everything at once. |
Completely up to you and Steve. I don't see a reason why they would need to be separate, but if you think they should be, I wouldn't argue. |
Building over @SteveSandersonMS PR to demonstrate the end-to-end experience when ai models/deployments are configured at the host level only.
Microsoft Reviewers: Open in CodeFlow