Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/django 3.0 #2431

Merged
merged 9 commits into from
Mar 29, 2020
Merged

Upgrade/django 3.0 #2431

merged 9 commits into from
Mar 29, 2020

Conversation

oleast
Copy link
Member

@oleast oleast commented Feb 12, 2020

What kind of a pull request is this?

  • QA / Code Review

Code Checklist

  • The code follows dotkom code style
  • The code passes the defined tests
  • I have added tests for the code I added
  • I have provided documentation for the code I added
  • The code is ready to be merged

(Possible) Breaking Changes

  • The changes are backwards compatible

Description of changes

Upgrading Django to version 3, along with a lot of other dependencies to support it.
There are a few things that have been changed for Django support, but also a lot of tests that have been fixed because of changes in how Django Dynamic Fixtures creates model instances (new major version of the lib).

Screenshot(s) if appropriate

@oleast oleast force-pushed the upgrade/django-3.0 branch from 65a0b0f to fcd9e28 Compare March 29, 2020 07:53
@oleast oleast requested a review from henrikhorluck March 29, 2020 09:21
Copy link
Member

@henrikhorluck henrikhorluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!

I really think we should fix some of the deprecation warning you get when running make test-backend before merging, several thousand lines is not fun, I opened a PR to django-watson, that will fix some of it etianen/django-watson#270, eventually you can just use a git-dependency from my fork.

You forgot this ugettext

from django.utils.translation import ugettext as _

requirements.txt Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@oleast
Copy link
Member Author

oleast commented Mar 29, 2020

Great work so far!

I really think we should fix some of the deprecation warning you get when running make test-backend before merging, several thousand lines is not fun, I opened a PR to django-watson, that will fix some of it etianen/django-watson#270, eventually you can just use a git-dependency from my fork.

I've seen the deprecation warnings, and and they are quite annoying. The problem is that they are for Django 4, which is set to release in 2022. Some libs may not get to fixing those until close to that date.

@henrikhorluck
Copy link
Member

As far as I can see on the deprecation warnings, the by far most common, and guilty for >10k of the lines was django-watson, which we have a potential fix for, and as long as that is fixed, and we remove django-oauth-toolkit, I think we should be relatively good

@oleast oleast requested a review from henrikhorluck March 29, 2020 14:42
Copy link
Member

@henrikhorluck henrikhorluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Would love if you also created an issue to clean up the warnings when running tests, because I think there ideally shouldn't be any 🙃

@oleast oleast merged commit 872d1d6 into develop Mar 29, 2020
@oleast oleast deleted the upgrade/django-3.0 branch March 29, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants