-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade/django 3.0 #2431
Upgrade/django 3.0 #2431
Conversation
65a0b0f
to
fcd9e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far!
I really think we should fix some of the deprecation warning you get when running make test-backend
before merging, several thousand lines is not fun, I opened a PR to django-watson
, that will fix some of it etianen/django-watson#270, eventually you can just use a git-dependency from my fork.
You forgot this ugettext
onlineweb4/apps/authentication/views.py
Line 15 in e1c8505
from django.utils.translation import ugettext as _ |
I've seen the deprecation warnings, and and they are quite annoying. The problem is that they are for Django 4, which is set to release in 2022. Some libs may not get to fixing those until close to that date. |
As far as I can see on the deprecation warnings, the by far most common, and guilty for >10k of the lines was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Would love if you also created an issue to clean up the warnings when running tests, because I think there ideally shouldn't be any 🙃
What kind of a pull request is this?
Code Checklist
(Possible) Breaking Changes
Description of changes
Upgrading Django to version 3, along with a lot of other dependencies to support it.
There are a few things that have been changed for Django support, but also a lot of tests that have been fixed because of changes in how Django Dynamic Fixtures creates model instances (new major version of the lib).
Screenshot(s) if appropriate