Issue #210: validate line ending and file encodings

Signed-off-by: alexmerlin <[email protected]>
dotkernel · Jan 5, 2024 · 30692ee · 30692ee
1 parent 93cb43c
commit 30692ee
Show file tree

Hide file tree

Showing 16 changed files with 2,591 additions and 2,559 deletions.
diff --git a/.github/workflows/check-encoding.yml b/.github/workflows/check-encoding.yml
@@ -0,0 +1,24 @@
+on:
+  - push
+
+name: Check File Encodings
+
+jobs:
+  check_encoding:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+
+      - name: Check file encodings
+        run: |
+          find . -type f ! -path "./.git/*" -exec sh -c '
+            for file do
+              encoding=$(file -bi "$file" | awk -F "=" '{print $2}')
+              if [ "$encoding" != "utf-8" ]; then
+                echo "File $file has encoding $encoding"
+                exit 1
+              fi
+            done
+          ' sh {} +
diff --git a/phpcs.xml b/phpcs.xml
@@ -7,6 +7,7 @@
     <arg name="colors"/>
     <arg name="extensions" value="php"/>
     <arg name="parallel" value="80"/>
+    <arg name="encoding" value="utf-8"/>
 
     <!-- Show progress -->
     <arg value="p"/>
@@ -21,4 +22,11 @@
 
     <!-- Include all rules from the Laminas Coding Standard -->
     <rule ref="LaminasCodingStandard"/>
+    <rule ref="Generic.Files.ByteOrderMark"/>
+    <rule ref="Generic.Files.EndFileNewline"/>
+    <rule ref="Generic.Files.LineEndings">
+        <properties>
+            <property name="eolChar" value="\n"/>
+        </properties>
+    </rule>
 </ruleset>
diff --git a/public/images/app/favicon/browserconfig.xml b/public/images/app/favicon/browserconfig.xml
@@ -1,9 +1,9 @@
-<?xml version="1.0" encoding="utf-8"?>
-<browserconfig>
-    <msapplication>
-        <tile>
-            <square150x150logo src="/mstile-150x150.png"/>
-            <TileColor>#2d89ef</TileColor>
-        </tile>
-    </msapplication>
-</browserconfig>
+<?xml version="1.0" encoding="utf-8"?>
+<browserconfig>
+    <msapplication>
+        <tile>
+            <square150x150logo src="/mstile-150x150.png"/>
+            <TileColor>#2d89ef</TileColor>
+        </tile>
+    </msapplication>
+</browserconfig>
diff --git a/src/Admin/src/Adapter/AuthenticationAdapter.php b/src/Admin/src/Adapter/AuthenticationAdapter.php
@@ -186,7 +186,7 @@ private function validateConfig(): void
     /**
      * @throws Exception
      */
-    private function checkMethod(Admin $identityClass, string $methodName): void
+    private function checkMethod(Admin $identityClass, string $methodName, int $a): void
     {
         if (! method_exists($identityClass, $methodName)) {
             throw new Exception(sprintf(

diff --git a/src/App/assets/images/favicon/browserconfig.xml b/src/App/assets/images/favicon/browserconfig.xml
@@ -1,9 +1,9 @@
-<?xml version="1.0" encoding="utf-8"?>
-<browserconfig>
-    <msapplication>
-        <tile>
-            <square150x150logo src="/mstile-150x150.png"/>
-            <TileColor>#2d89ef</TileColor>
-        </tile>
-    </msapplication>
-</browserconfig>
+<?xml version="1.0" encoding="utf-8"?>
+<browserconfig>
+    <msapplication>
+        <tile>
+            <square150x150logo src="/mstile-150x150.png"/>
+            <TileColor>#2d89ef</TileColor>
+        </tile>
+    </msapplication>
+</browserconfig>
diff --git a/src/App/assets/js/components/_language.js b/src/App/assets/js/components/_language.js
@@ -1,30 +1,30 @@
-$(document).ready(function () {
-    $(document).on('click', '.language-container .language-active', function () {
-        $(".language-list").slideToggle("fast");
-    });
-
-    $(document).on('click', '.language-container .language', function () {
-        let language = $(this);
-        let languageKey = $(this).data('language-key');
-        let langImageSrc = language.find('img').attr('src');
-
-        $('.language-container .language-active').find('img').attr('src', langImageSrc);
-
-        $(".language-list").slideToggle("fast");
-        $(".language-list .language").removeClass('active');
-
-        $.post(
-            '/language/change',
-            {
-                'languageKey': languageKey
-            }
-        )
-        .done(function () {
-            // activate language in list
-            language.addClass('active');
-
-            // reload page
-            location.reload();
-        });
-    });
-});
+$(document).ready(function () {
+    $(document).on('click', '.language-container .language-active', function () {
+        $(".language-list").slideToggle("fast");
+    });
+
+    $(document).on('click', '.language-container .language', function () {
+        let language = $(this);
+        let languageKey = $(this).data('language-key');
+        let langImageSrc = language.find('img').attr('src');
+
+        $('.language-container .language-active').find('img').attr('src', langImageSrc);
+
+        $(".language-list").slideToggle("fast");
+        $(".language-list .language").removeClass('active');
+
+        $.post(
+            '/language/change',
+            {
+                'languageKey': languageKey
+            }
+        )
+        .done(function () {
+            // activate language in list
+            language.addClass('active');
+
+            // reload page
+            location.reload();
+        });
+    });
+});
diff --git a/src/App/assets/js/components/_profile.js b/src/App/assets/js/components/_profile.js
@@ -1,6 +1,6 @@
-$(document).ready(function () {
-    /* Search patterns */
-    $('.collapse-menu').on('click', function () {
-        $('.profile-action-menu').slideToggle();
-    });
-});
+$(document).ready(function () {
+    /* Search patterns */
+    $('.collapse-menu').on('click', function () {
+        $('.profile-action-menu').slideToggle();
+    });
+});