v117.0 #28
Merged
v117.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m, a=RyanVM Fixes a defect where the intended behavior is to show the translations panel intro message while the user stays on the same URI, but not after they navigate away. However, the intro message was continuing to display for that URI even after the user would navigate away and return within the same session. Differential Revision: https://phabricator.services.mozilla.com/D185886
…um, a=RyanVM Caches the firstShowUriSpec value on the TranslationsParent object instead of the TranslationsPanel object. Caching this value on the panel led to unintended behavior in automated testing in specific scenarios when the same test page is used by multiple tests, and the cached value is unintentionally persisted between test cases. Differential Revision: https://phabricator.services.mozilla.com/D185887
…tatum, a=RyanVM Fixes a defect in which the TranslationsPanel error box was unintentionally being shown only after browser restart and when navigating to a page that has auto-translate enabled. Differential Revision: https://phabricator.services.mozilla.com/D185888
… r=gregtatum, a=RyanVM Refactors the entire Translations test suite to assert the expected panel view and its associated visible elements every time the translations panel is opened. Differential Revision: https://phabricator.services.mozilla.com/D185889
… Nimbus; r=nordzilla, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D186661
…=nordzilla, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D186660
…tatum, a=RyanVM Removes a getter for the translationsButton panel element that was defined twice with two different names, unifying the usage across the implementation. Differential Revision: https://phabricator.services.mozilla.com/D185885
…=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D186771
… all Translations tests also. a=test-only
…X_117_0_BUILD2 a=release CLOSED TREE DONTBUILD
…X_117_0_RELEASE a=release CLOSED TREE DONTBUILD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox v117.0
Merge in changes from upstream (v117.0)
Checklist
REVISIONfile is ready to be updated