Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react-vue): add mention of graphqlsp to the docs #9773

Merged
merged 7 commits into from
Dec 1, 2023

Conversation

JoviDeCroock
Copy link
Contributor

Description

After talking about and integrating GraphQLSP into GraphQL Hive we wanted to mention this in the documentation.

I wasn't sure where to add it, feel free to change this yourselves or ask me to do so 😅

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

The new documentation page, at the top we see the mention of installing the VSCode extension to get the best GraphQL developer experience, followed by an alternative to install GraphQLSP the TypeScript LSP plugin for the aforementioned GraphQL developer experience.

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: ed32846

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -480,14 +480,35 @@ From simple Queries to more advanced Fragments-based ones, GraphQL Code Generato

**What's next?**

To get the best GraphQL development experience, we recommend installing the [GraphQL VSCode extension](https://marketplace.visualstudio.com/items?itemName=GraphQL.vscode-graphql) to get:
To get the best GraphQL development experience, we recommend installing the [GraphQLSP](https://github.com/0no-co/GraphQLSP) package to get:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a screenshot to demonstrate the functionality? It could help convince people (optional though).

@n1ru4l n1ru4l merged commit 967a34d into dotansimha:master Dec 1, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants