Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Client Preset Persisted Documents documentation with hashAlgorithm options #9760

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

schweetheart
Copy link
Contributor

@schweetheart schweetheart commented Nov 20, 2023

Updates Client Preset - Persisted Documents documentation

Description

Updates documentation with persistedDocuments.hashAlgorithm options example from #9353

Related # (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Updates documentation
Copy link

changeset-bot bot commented Nov 20, 2023

⚠️ No Changeset found

Latest commit: 7404880

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schweetheart schweetheart marked this pull request as ready for review November 20, 2023 20:51
@schweetheart schweetheart changed the title Update preset-client.mdx Updates Client Preset Persisted Documents documentation with hashAlgorithm options Nov 20, 2023
@Urigo Urigo requested a review from n1ru4l November 23, 2023 16:10
@n1ru4l
Copy link
Collaborator

n1ru4l commented Nov 30, 2023

Hey @schweetheart, thank you fort this contribution. Could you please run prettier on the changed files to resolve the formatting issues and make the CI pipeline happy?

Optional, but not necessary, maybe this option should be mentioned under a new h3 heading, so it also shows up in the navigation?

@schweetheart
Copy link
Contributor Author

schweetheart commented Nov 30, 2023

@n1ru4l, Thanks for the feedback!
Done.

@n1ru4l
Copy link
Collaborator

n1ru4l commented Dec 1, 2023

@schweetheart thank you for adding this to the docs!

@n1ru4l n1ru4l merged commit 71c92d5 into dotansimha:master Dec 1, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants