fix(ci): pin nextjs version for nextjs-swc example #9737

YassinEldeeb · 2023-10-26T07:03:11Z

No description provided.

changeset-bot · 2023-10-26T07:03:14Z

⚠️ No Changeset found

Latest commit: d714dcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2023-10-26T07:07:02Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-codegen/cli`	`5.0.1-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/core`	`4.0.1-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/add`	`5.0.1-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/fragment-matcher`	`5.0.1-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/introspection`	`4.0.1-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/schema-ast`	`4.0.1-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/visitor-plugin-common`	`4.1.0-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/typescript-document-nodes`	`4.0.2-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/gql-tag-operations`	`4.0.2-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/typescript-operations`	`4.1.0-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/typescript-resolvers`	`4.0.2-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/typed-document-node`	`5.0.2-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/typescript`	`4.0.2-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/client-preset`	`4.2.0-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/graphql-modules-preset`	`4.0.2-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/testing`	`3.0.1-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎
`@graphql-codegen/plugin-helpers`	`5.0.2-alpha-20231026070541-cb05739d0`	npm ↗︎ unpkg ↗︎

github-actions · 2023-10-26T07:11:46Z

💻 Website Preview

The latest changes are available as preview in: https://f6b944a8.graphql-code-generator.pages.dev

YassinEldeeb · 2023-10-26T07:16:51Z

examples/react/nextjs-swr/codegen.ts

@@ -1,4 +1,5 @@
 // eslint-disable-next-line import/no-extraneous-dependencies
+// @ts-ignore


for some reason though, I faced some errors regarding:

Type error: Cannot find module '@graphql-codegen/cli' or its corresponding type declarations. 1 | // eslint-disable-next-line import/no-extraneous-dependencies > 2 | import { CodegenConfig } from '@graphql-codegen/cli'

when running yarn workspace example-react-nextjs-swr run build locally which I skipped with a // @ts-ignore for now, do you have any ideas on why is it throwing that?

YassinEldeeb · 2023-10-26T07:29:43Z

not sure why End2End step fails @saihaj

eddeee888 · 2024-04-24T11:51:32Z

examples/programmatic-typescript/src/gql.generated.ts

+  ID: { input: string; output: string };
+  String: { input: string; output: string };
+  Boolean: { input: boolean; output: boolean };
+  Int: { input: number; output: number };
+  Float: { input: number; output: number };


These were never updated because codegen/tests are executed sequentially... and this example was after some other failing tests 😓

eddeee888 · 2024-04-24T11:54:03Z

examples/react/nextjs-swr/hooks/use-query.ts

@@ -20,7 +20,7 @@ export function useGraphQL<TResult, TVariables>(
      document.definitions.find(isOperationDefinition)?.name,
      variables,
    ] as const,
-    async (_key: string, variables: any) =>
+    async ([_key, variables]: any) =>


Looks like the current version of swr keeps the array as-is: https://swr.vercel.app/docs/arguments#multiple-arguments

In the previous versions (< 2.0.0), The fetcher function will receive the spreaded arguments from original key when the key argument is array type. E.g., key [url, token] will become 2 arguments (url, token) for fetcher function.

eddeee888 · 2024-04-24T11:54:41Z

examples/typescript-graphql-request/src/main.ts

-getPeople().then(res => console.log(res));
-getPeople(10).then(res => console.log(res));


These calls cause the Jest tests to fail. These also look like debugging statements that were never removed 🤔

eddeee888 · 2024-04-24T11:59:20Z

scripts/print-example-ci-command.js

@@ -4,7 +4,7 @@ const fg = require('fast-glob');

 const packageJSON = fg.sync(['examples/**/package.json'], { ignore: ['**/node_modules/**'] });

-const ignoredPackages = ['example-react-nextjs-swr'];
+const ignoredPackages = [];


We can now remove the example from the ignored array 🎉

I'll keep the current implementation in case we need to ignore tests in the future (hope that time never comes! 🤞 )

YassinEldeeb

looks good, @saihaj or @enisdenjo can you take a last look before merging?

saihaj

Thank you 🙏🏼

YassinEldeeb commented Oct 26, 2023

View reviewed changes

dotansimha requested a review from saihaj October 26, 2023 07:22

eddeee888 force-pushed the pin-nextjs-version branch 2 times, most recently from 1eaacf6 to 5a226cd Compare April 24, 2024 10:49

eddeee888 reviewed Apr 24, 2024

View reviewed changes

YassinEldeeb commented Apr 24, 2024

View reviewed changes

YassinEldeeb and others added 6 commits April 25, 2024 12:46

pin nextjs version

f151cf5

Revert ts-ignore

7d7bfe4

Remove nextjs-swr from ignored

d257895

Remove console.log which trips up Jest error

a8127dc

Apply new generated types

a13dccc

Fix fetcher usage

ec5c7cb

eddeee888 force-pushed the pin-nextjs-version branch from e905c28 to ec5c7cb Compare April 25, 2024 02:46

Merge branch 'master' into pin-nextjs-version

d714dcc

saihaj approved these changes Apr 25, 2024

View reviewed changes

saihaj merged commit 512190a into master Apr 25, 2024
19 checks passed

saihaj deleted the pin-nextjs-version branch April 25, 2024 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ci): pin nextjs version for nextjs-swc example #9737

fix(ci): pin nextjs version for nextjs-swc example #9737

YassinEldeeb commented Oct 26, 2023

changeset-bot bot commented Oct 26, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023 •

edited

Loading

YassinEldeeb Oct 26, 2023 •

edited

Loading

YassinEldeeb commented Oct 26, 2023

eddeee888 Apr 24, 2024

eddeee888 Apr 24, 2024 •

edited

Loading

eddeee888 Apr 24, 2024 •

edited

Loading

eddeee888 Apr 24, 2024 •

edited

Loading

YassinEldeeb left a comment

saihaj left a comment

		@@ -1,4 +1,5 @@
		// eslint-disable-next-line import/no-extraneous-dependencies
		// @ts-ignore

		getPeople().then(res => console.log(res));
		getPeople(10).then(res => console.log(res));

fix(ci): pin nextjs version for nextjs-swc example #9737

fix(ci): pin nextjs version for nextjs-swc example #9737

Conversation

YassinEldeeb commented Oct 26, 2023

changeset-bot bot commented Oct 26, 2023 • edited Loading

⚠️ No Changeset found

github-actions bot commented Oct 26, 2023

🚀 Snapshot Release (alpha)

github-actions bot commented Oct 26, 2023 • edited Loading

💻 Website Preview

YassinEldeeb Oct 26, 2023 • edited Loading

Choose a reason for hiding this comment

YassinEldeeb commented Oct 26, 2023

eddeee888 Apr 24, 2024

Choose a reason for hiding this comment

eddeee888 Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

eddeee888 Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

eddeee888 Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

YassinEldeeb left a comment

Choose a reason for hiding this comment

saihaj left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 26, 2023 •

edited

Loading

🚀 Snapshot Release (`alpha`)

github-actions bot commented Oct 26, 2023 •

edited

Loading

YassinEldeeb Oct 26, 2023 •

edited

Loading

eddeee888 Apr 24, 2024 •

edited

Loading

eddeee888 Apr 24, 2024 •

edited

Loading

eddeee888 Apr 24, 2024 •

edited

Loading