Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include @graphql-codegen/client-preset in @graphql-codegen/cli by default #9601

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Aug 17, 2023

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: d29094c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

diff --git a/website/algolia-lockfile.json b/website/algolia-lockfile.json
index 4a8d4b81a..0a8974dac 100644
--- a/website/algolia-lockfile.json
+++ b/website/algolia-lockfile.json
@@ -913,7 +913,7 @@
         "anchor": "setup"
       }
     ],
-    "content": "2c4dd42cec4906229f4594ede093a8d8",
+    "content": "daa62b8fb6719b45975db3ffb56abdbd",
     "url": "https://www.the-guild.dev/graphql/codegen/docs/getting-started/installation",
     "domain": "https://www.the-guild.dev/graphql/codegen",
     "hierarchy": [

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/cli 5.0.1-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/core 4.0.1-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/add 5.0.1-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/fragment-matcher 5.0.1-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/introspection 4.0.1-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/schema-ast 4.0.1-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/visitor-plugin-common 4.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 4.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 4.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 4.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 4.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 5.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 4.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 4.2.0-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 4.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/testing 3.0.1-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎
@graphql-codegen/plugin-helpers 5.0.2-alpha-20231019221049-f2a3ec403 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

💻 Website Preview

The latest changes are available as preview in: https://48ac85b3.graphql-code-generator.pages.dev

@beerose beerose requested review from dotansimha and n1ru4l August 18, 2023 08:37
@saihaj
Copy link
Collaborator

saihaj commented Oct 19, 2023

can you please rebase this one @beerose

@saihaj saihaj added the waiting-for-answer Waiting for answer from author label Oct 19, 2023
@beerose
Copy link
Contributor Author

beerose commented Oct 19, 2023

Done @saihaj. Am I free to merge it now, or do we want to wait with this change?

@saihaj saihaj merged commit e176eab into master Oct 25, 2023
12 of 15 checks passed
@saihaj saihaj deleted the client-preset-cli branch October 25, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-answer Waiting for answer from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants