Fix resolveReference being generated as required when using generateInternalResolversIfNeeded.__resolveReference
#10230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the resolver required
🦋 Changeset detectedLatest commit: d7a711a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/visitor-plugin-common |
5.6.1-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.13-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.13-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.4.1-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.4.2-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.13-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.1.3-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.6.0-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.13-alpha-20250118075542-d7a711aa2c16cb9f3202c407191d18b543dc8569 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://c6e65f1a.graphql-code-generator.pages.dev |
eddeee888
changed the title
resolveReference being generated as requiredresolveReference being generated as required when using generateInternalResolversIfNeeded.__resolveReference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First implementation is #9989
__resolveReference's default behaviour when not declared is to pass the ref to subsequent resolvers i.e. becoming theparent. So, it means we don't have to make this resolver required.This patch makes
__resolveReferenceoptional whengenerateInternalResolversIfNeeded.__resolveReferenceis set to true.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration