Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match feature #14

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

match feature #14

wants to merge 11 commits into from

Conversation

paales
Copy link
Contributor

@paales paales commented Jul 28, 2021

No description provided.

@@ -1,5 +1,6 @@
import { getInput, setOutput, setFailed } from "@actions/core";
import { getInput, setOutput, setFailed, debug } from "@actions/core";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like you're using it :)

@@ -3,11 +3,12 @@ module.exports = `query($repo: String!, $owner: String!, $branch: String!) {
ref(qualifiedName: $branch) {
target {
... on Commit {
deployments(last: 1) {
deployments(last: 100) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very comfortable with querying 100 deployments every time. Maybe add that as a configuration option?

@dorshinar
Copy link
Owner

Thank you for taking the time to implement this! That's very cool
There are a few small remarks I've left in the files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants