add missing match fields #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for the recent update, glad to see you are still working on this project.
Using the match v5 api led into an error caused by some fields existing in the API that were not defined in the ParticipantDto class. Turns out it's something missing in the Riot documentation. This PR fixes it.
As a side note, those undefined fields trigger an error when trying to build the Dto (
RiotAPI\Base\Objects\ApiObject::90). I believe it would be better if the Dto was still instantiated without the missing fields instead of failing. Looking at the linked PR, it seems that riot is regularly adding new fields, which would cause the Dto instantiation to fail each time