Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/243 compatibility #804

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Thargelion
Copy link

Description

  • Increase the gradle.properties pluginUntilBuild to version 243.*
  • Fix CONTRIBUTING file so it now says GITHUB_ACTOR instead of GITHUB_TOKEN when configuring the username environment variable
  • Added a sustitution (waterfront) to overzealous remark library because it wasn't found at any of the provided repositories. It seems that the waterfront repository is the maintained one.

Motivation and Context

The plugin wasn't compatible with 2024.3 versions.

Closes #803

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-Functional Change (non-user facing changes)

Checklist:

  • My code follows the code style of this project (./gradlew check passes clean).
    • Tip: If you have lint issues just run ./gradlew :ktlintMainSourceSetFormat.
  • I updated the version.
  • I updated the changelog with the new functionality.

@Unthrottled
Copy link
Member

Hey! thanks for the contributions. Appreciate it. More work had to be done to get it to compile/work for 2024.3.

Fix CONTRIBUTING file so it now says GITHUB_ACTOR instead of GITHUB_TOKEN when configuring the username environment variable

☝️ I'll take that though if you want to update the contributions to just having that.

@Thargelion
Copy link
Author

Thanks you for all your work!

OK!, will revert all the other changes so you can merge the typo fix if desired.

I'm currently using this fork for my 2024.3 ides. Will let you know if any issue happen as some kind of beta tester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024.3 Support
2 participants