Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update for 1.0.0-alpha #82

Merged
merged 11 commits into from
Jul 25, 2024
Merged

feat: update for 1.0.0-alpha #82

merged 11 commits into from
Jul 25, 2024

Conversation

glihm
Copy link
Contributor

@glihm glihm commented Jul 18, 2024

Due to changes for the compiler and namespaces support, the workspaces are not quite well supported for libraries like crates which are pure logic not related to Dojo into sozo.

We need to iterate on that.

The branch 1.0.0-alpha.3 can for now be used to test the import of origami in other projects.

# other project Scarb.toml
# Don't write here the model if you don't need to deploy it, but only using it
# in cairo code to interact with it.
[[target.dojo]]
build-external-contracts = [
    "origami_token::components::token::erc20::erc20_balance::ERC20BalanceModel",
    # ...
]

[tool.dojo.world.namespace]
default = "other_project"
mappings = { "origami_token" = "other_project_token" }

Origami structure has been revised with virtual workspace and separates packages for each of the different libraries.

Examples should be maintained elsewhere to focus here on testing and updating the library following Dojo versions.

Tasks

@glihm glihm marked this pull request as draft July 18, 2024 04:41
@glihm glihm changed the title chore: update for 1.0.0-alpha.1 feat: update for 1.0.0-alpha.1 Jul 18, 2024
@glihm
Copy link
Contributor Author

glihm commented Jul 22, 2024

@bal7hazar for governance, we no longer have a ContractAddress mapping in the world for contracts by tag instead. We could add a double mapping in the world. But as I've seen in execute_transaction it's always targeting a Dojo contract it seems, we should be able to switch to tag instead for the proposal to target (instead of a contract address).

Would appreciate your feedback on that. 🫡

@glihm glihm changed the title feat: update for 1.0.0-alpha.1 feat: update for 1.0.0-alpha Jul 25, 2024
@glihm glihm marked this pull request as ready for review July 25, 2024 05:29
@glihm
Copy link
Contributor Author

glihm commented Jul 25, 2024

@bal7hazar @notV4l @ponderingdemocritus review welcome for the new structure.

Governance:

  • will be updated but can be added later.

Algebra:

  • some warnings at compile time to solve, not blocking.
  • test failing related to the build warnings somehow and some traits to specify.

@ponderingdemocritus
Copy link
Contributor

yeah lets ship - and make an issue for the gov

@glihm glihm merged commit 520d77f into main Jul 25, 2024
9 checks passed
@glihm glihm deleted the 1.0.0-alpha.1 branch July 25, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants