-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELO rating #61
ELO rating #61
Conversation
@ponderingdemocritus @tarrencev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool. Do you think it is worth having a match maker module that is easily reusable by games? So people don't end up copy/pasting the example?
@tarrencev I don't think we can have it generic enough to make it compatible with all games (for instance if you want to do 1v1 or NvN or 1vN, etc.). If we are able to get enough feedbacks after a period of usage, maybe we could consider it again. In addition, I was also thinking to maybe have a single deployed match marker world to allow people to find an opponent among a selected list of games (worlds), so all the ratings of all subscribed games will be centralised inside a singe Registry (which open the door to Gaming Identity, etc.). |
@tarrencev @ponderingdemocritus |
Note: PR made to Alexandria keep-starknet-strange/alexandria#296 Edit (2022-04-22): PR has been merged but we will need to have dojo to be compatible with starknet 2.6.3 to be able to add alexandria as a dep. |
@tarrencev @ponderingdemocritus are you comfortable to merge it as it is? I will update these helpers once we are able to support the latest version of Alexandria (currently blocked by dojoengine/dojo#1659). I think creating a temporary |
Yeah lets do it |
Closes #60
Introduced changes
Checklist