Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use starknet::ContractAddress in #[system] #997

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

notV4l
Copy link
Collaborator

@notV4l notV4l commented Oct 9, 2023

@credence0x
Copy link
Contributor

Is it possible to just use IWorldDispatcher instead of ContractAddress? if we can't use the dispatcher we should probably change the variable name to world_address instead of world_dispatcher

@wraitii
Copy link
Contributor

wraitii commented Oct 9, 2023

Is it possible to just use IWorldDispatcher instead of ContractAddress? if we can't use the dispatcher we should probably change the variable name to world_address instead of world_dispatcher

Hm as a matter of fact it's the IWorldDispatcher which is stored, it just happens that the serialised data is identical. Probably better to change it.

@notV4l notV4l force-pushed the fix_system_contractaddress branch from 5142c57 to 34d0961 Compare October 10, 2023 10:40
@notV4l
Copy link
Collaborator Author

notV4l commented Oct 10, 2023

updated to world_address

@notV4l
Copy link
Collaborator Author

notV4l commented Oct 10, 2023

back to world_dispatcher: IWorldDispatcher

@tarrencev tarrencev merged commit 2331e76 into dojoengine:main Oct 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] system contracts can't be compiled
4 participants