World deployments with deterministic addresses #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrencev
changed the title
tarrencev
force-pushed
the
placeholder
branch
8 times, most recently
from
5d85fcc to
b7a4dd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
World deployer that deploys a placeholder contract and then replaces it with the actual contract impl
It allows us to get deterministic addresses based on the contract name, so we don't need to maintain an onchain registry
Downside is we can't use constructors. We need to use the initialize pattern. I think constructors will be uncommon with the dojo architecture (and aren't supported by sozo right now)